Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle pod assert err #44

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: handle pod assert err #44

merged 1 commit into from
May 7, 2024

Conversation

googs1025
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • refactor getTasks method, make code reusable
  • handle assertion failures gracefully to avoid panicking.
  • fix some typo

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

There is a refactoring involving the original method. Please assist in reviewing if the logic remains the same. thanks a lot!

lzlaa
lzlaa reviewed May 6, 2024
View reviewed changes
pkg/binder/binder_unit.go Outdated Show resolved Hide resolved
@googs1025 googs1025 requested a review from lzlaa May 6, 2024 11:33
@lzlaa
Copy link
Collaborator

lzlaa commented May 7, 2024

/lgtm

lzlaa
lzlaa previously approved these changes May 7, 2024
View reviewed changes
binacs
binacs reviewed May 7, 2024
View reviewed changes
pkg/binder/binder_unit.go Outdated Show resolved Hide resolved
binacs
binacs approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@binacs binacs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contributuion！

@NickrenREN NickrenREN merged commit 5035528 into kubewharf:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binacs binacs binacs approved these changes

@lzlaa lzlaa lzlaa left review comments

@XinyiSong XinyiSong Awaiting requested review from XinyiSong XinyiSong is a code owner

@Liumeng-lambert Liumeng-lambert Awaiting requested review from Liumeng-lambert

@NickrenREN NickrenREN Awaiting requested review from NickrenREN NickrenREN is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@googs1025 @lzlaa @binacs @NickrenREN