Add readme files for Backup and Restore #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
kyma-bot
removed
the
do-not-merge/work-in-progress
Disper
reviewed
Jan 10, 2025
Disper
reviewed
Jan 10, 2025
Disper
reviewed
Jan 13, 2025
Disper
reviewed
Jan 13, 2025
Disper
reviewed
Jan 13, 2025
Code review Co-authored-by: Michał 'Disper' Drzewiecki <[email protected]>
…d` label is being checked when looking for shoot
Disper
previously approved these changes
Jan 14, 2025
Disper
previously approved these changes
Jan 15, 2025
NHingerl
reviewed
Jan 15, 2025
hack/runtime-migrator/README-rr.md
Outdated
| | **output-path** | Path where generated report, and yamls will be saved. Directory has to exist. | `/tmp/` | | ||
| | **dry-run** | Dry-run flag. Has to be set to **false**, otherwise migrator will not apply the CRs on the KCP cluster. | `true` | | ||
| | **input-type** | Type of input to be used. Possible values: **txt** (will expect text file with one runtime identifier per line, [see the example](input/runtimeids_sample.txt)), and **json** (will expect `json` array with runtime identifiers, [see the example](input/runtimeids_sample.json)). | `json` | |
There was a problem hiding this comment.
Suggested change
| | **input-type** | Type of input to be used. Possible values: **txt** (will expect text file with one runtime identifier per line, [see the example](input/runtimeids_sample.txt)), and **json** (will expect `json` array with runtime identifiers, [see the example](input/runtimeids_sample.json)). | `json` | | |
| | **input-type** | Type of input to be used. Possible values: **txt** (expects a text file with one runtime identifier per line, [see the example](input/runtimeids_sample.txt)), and **json** (expects a `json` array with runtime identifiers, [see the example](input/runtimeids_sample.json)). | `json` | |
hack/runtime-migrator/README-rr.md
Outdated
| | **dry-run** | Dry-run flag. Has to be set to **false**, otherwise migrator will not apply the CRs on the KCP cluster. | `true` | | ||
| | **input-type** | Type of input to be used. Possible values: **txt** (will expect text file with one runtime identifier per line, [see the example](input/runtimeids_sample.txt)), and **json** (will expect `json` array with runtime identifiers, [see the example](input/runtimeids_sample.json)). | `json` | | ||
| | **input-file-path** | Path to the file containing Runtimes to be migrated. | `/path/to/input/file` | |
There was a problem hiding this comment.
Suggested change
| | **input-file-path** | Path to the file containing Runtimes to be migrated. | `/path/to/input/file` | | |
| | **input-file-path** | Path to the file containing the runtimes to be migrated. | `/path/to/input/file` | |
hack/runtime-migrator/README-rr.md
Outdated
| | **input-type** | Type of input to be used. Possible values: **txt** (will expect text file with one runtime identifier per line, [see the example](input/runtimeids_sample.txt)), and **json** (will expect `json` array with runtime identifiers, [see the example](input/runtimeids_sample.json)). | `json` | | ||
| | **input-file-path** | Path to the file containing Runtimes to be migrated. | `/path/to/input/file` | | ||
| | **backup-path** | Path to the directory containing backup files | `/path/to/input/file` | |
There was a problem hiding this comment.
Suggested change
| | **backup-path** | Path to the directory containing backup files | `/path/to/input/file` | | |
| | **backup-path** | Path to the directory containing backup files. | `/path/to/input/file` | |
hack/runtime-migrator/README-rr.md
Outdated
| | **input-file-path** | Path to the file containing Runtimes to be migrated. | `/path/to/input/file` | | ||
| | **backup-path** | Path to the directory containing backup files | `/path/to/input/file` | | ||
| | **restore-crb** | Flag determining whether Cluster Role Bindings should be restored | `/path/to/backup/dir` | |
There was a problem hiding this comment.
Suggested change
| | **restore-crb** | Flag determining whether Cluster Role Bindings should be restored | `/path/to/backup/dir` | | |
| | **restore-crb** | Flag determining whether ClusterRoleBindings are restored. | `/path/to/backup/dir` | |
hack/runtime-migrator/README-rr.md
Outdated
| | **backup-path** | Path to the directory containing backup files | `/path/to/input/file` | | ||
| | **restore-crb** | Flag determining whether Cluster Role Bindings should be restored | `/path/to/backup/dir` | | ||
| | **restore-oidc** | Flag determining whether OPenIDConnect resources should be restored | `/path/to/backup/dir` | |
There was a problem hiding this comment.
Suggested change
| | **restore-oidc** | Flag determining whether OPenIDConnect resources should be restored | `/path/to/backup/dir` | | |
| | **restore-oidc** | Flag determining whether OPenIDConnect resources are restored. | `/path/to/backup/dir` | |
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
Co-authored-by: Nina Hingerl <[email protected]>
NHingerl
reviewed
Jan 16, 2025
Co-authored-by: Nina Hingerl <[email protected]>
NHingerl
approved these changes
Jan 16, 2025
Disper
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#557