Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme files for Backup and Restore #596
Add readme files for Backup and Restore #596
Changes from 23 commits
562e67a
35d78b3
ac3ee3c
6281980
a7ba228
4ff26cc
e096475
0041766
151d9dd
c0e46ed
6c1b9ce
7f9adba
9a532f2
610233f
7405052
af8c686
2682469
0fe4b1b
05e5aee
dc5f4b2
cc002a8
d11cb2e
20db9e8
e993bc7
6a1e1bf
5e58fe4
a9a0b5d
f5df405
9ce2278
689b735
759c9ac
3004032
fddebc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: Why did you format the execution example as bold? Is there some special meaning I'm missing that justifies highlighting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is the reason of this highlighting (@akgalwas ?) without knowing that I've just applied your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the "only" mean here? Are there other resources that it doesn't fetch? Are there other steps it doesn't proceed with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many more resources on the cluster but the backup app works only with those mentioned as they're only managed by KIM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intro sentences to lists should be complete sentences and not embedded. Because of that, I'd suggest changing the phrasing like we did in the other two README document.
However, this is probably not scope of review you asked for :D , so I'm not going to add it to my suggestions. Feel free to align this doc with the other READMES if you like consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in 759c9ac