feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_mounts #3038
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ironAiken2
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.9% (-0% 🔻) |
398/8116 |
| 🔴 | Branches | 4.24% (-0% 🔻) |
239/5635 |
| 🔴 | Functions | 2.95% (-0% 🔻) |
78/2643 |
| 🔴 | Lines | 4.82% (-0% 🔻) |
383/7941 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 9c53670
ironAiken2
force-pushed
the
feat/open-folder-explorer-from-session-detail-panel
branch
from
a864003 to
e710c92
Compare
github-actions
bot
added
area:lib
ironAiken2
force-pushed
the
feat/open-folder-explorer-from-session-detail-panel
branch
from
e710c92 to
8468084
Compare
5 tasks
ironAiken2
changed the title
ironAiken2
changed the title
ironAiken2
force-pushed
the
feat/open-folder-explorer-from-session-detail-panel
branch
2 times, most recently
from
61191e3 to
b9992c8
Compare
Merge activity
|
…using vfolder_mounts (#3038) resolves #3051 (FR-249) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> >lablup/backend.ai#3461 PR must be merged first. <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> This PR makes folder explorer available in the Session Detail Panel. In versions prior to Backend.AI Core 24.12.0, the vfolder_nodes field is not provided. Therefore, you must use the `mounts` field of the `compute_session_node` query. Mounts field does not provide vfolder name. So we need to use `vfolder_mounts` field in legacy `compute_session` query. vfolder_mounts' provide the name of the vfolder in the same order as the `mounts' field in `compute_session_node'. **Feature:** - allow to open folder explorer in session detail panel **How to test:** - checkout Core branch to [lablup/backend.ai#3461](lablup/backend.ai#3461) - open session detail panel. you can open session detail panel via using query string (?sessionDetail=<sessionID>) - click the folder icon in session detail panel - Verify that folder opener works for the vfolder you clicked on (name, contents, etc. match) **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feat/open-folder-explorer-from-session-detail-panel
branch
from
b9992c8 to
9c53670
Compare
graphite-app
bot
deleted the
feat/open-folder-explorer-from-session-detail-panel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3051 (FR-249)
This PR makes folder explorer available in the Session Detail Panel.
In versions prior to Backend.AI Core 24.12.0, the vfolder_nodes field is not provided. Therefore, you must use the
mountsfield of thecompute_session_nodequery.Mounts field does not provide vfolder name. So we need to use
vfolder_mountsfield in legacycompute_sessionquery. vfolder_mounts' provide the name of the vfolder in the same order as themounts' field incompute_session_node'.Feature:
How to test:
Checklist: (if applicable)