feat(FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

ironAiken2 · 2025-01-20T05:39:35Z

resolves #3051 (FR-249)

lablup/backend.ai#2987 PR must be merged first.

This PR makes folder explorer available in the Session Detail Panel.

In versions after to Backend.AI Core 24.12.0, the vfolder_nodes field is provided.

Feature:

allow to open folder explorer in session detail panel

How to test:

checkout Core branch to feat(BA-604): Add image_node and vfolder_node fields to ComputeSession schema backend.ai#2987
open session detail panel. you can open session detail panel via using query string (?sessionDetail=)
click the folder icon in session detail panel
Verify that folder opener works for the vfolder you clicked on (name, contents, etc. match)

Checklist: (if applicable)

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

ironAiken2 · 2025-01-20T05:39:53Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

agatha197

LGTM

github-actions · 2025-01-24T10:06:45Z

Coverage report for `./react`

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from 2e8f90c

src/lib/backend.ai-client-esm.ts

react/src/components/SessionDetailContent.tsx

yomybaby

On 25.3.0 manager, I got a below error. Please check

No data returned for operation `SessionDetailContentQuery`, got error(s): Cannot query field 'vfolder_nodes' on type 'ComputeSessionNode'. Did you mean 'vfolder_mounts' or 'kernel_nodes'? See the error `source` property for more information.

ironAiken2 · 2025-02-24T02:10:49Z

On 25.3.0 manager, I got a below error. Please check

No data returned for operation `SessionDetailContentQuery`, got error(s): Cannot query field 'vfolder_nodes' on type 'ComputeSessionNode'. Did you mean 'vfolder_mounts' or 'kernel_nodes'? See the error `source` property for more information.

allow vfolder_nodes PR will be merged in version 25.3.2 and vfolder ordering PR is merged in version 25.3.0 and backported in version 24.09. So I changed supported version in WebUI. @yomybaby

yomybaby

Please resolve lint error

ironAiken2 · 2025-03-04T04:02:20Z

Fixed.

This lint error was not caused by the impact of this PR. It was caused by an unused variable in app.tsx.

yomybaby

LGTM

graphite-app · 2025-03-04T08:53:51Z

Merge activity

Mar 4, 3:53 AM EST: A user added this pull request to the Graphite merge queue.
Mar 4, 3:55 AM EST: A user merged this pull request with the Graphite merge queue.

…older_nodes (#3052) resolves #3051 (FR-249)  >lablup/backend.ai#2987 PR must be merged first.  This PR makes folder explorer available in the Session Detail Panel. In versions after to Backend.AI Core 24.12.0, the vfolder_nodes field is provided. **Feature:** - allow to open folder explorer in session detail panel **How to test:** - checkout Core branch to lablup/backend.ai#2987 - open session detail panel. you can open session detail panel via using query string (?sessionDetail=<sessionID>) - click the folder icon in session detail panel - Verify that folder opener works for the vfolder you clicked on (name, contents, etc. match) **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

github-actions bot added the area:lib label Jan 20, 2025

github-actions bot assigned ironAiken2 Jan 20, 2025

github-actions bot added the size:L label Jan 20, 2025

ironAiken2 mentioned this pull request Jan 20, 2025

feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_mounts #3038

Merged

5 tasks

ironAiken2 changed the title ~~feat: open folder explorer from session detail panel using vfolder_nodes~~ feat(FR-249): open folder explorer from session detail panel using vfolder_nodes Jan 20, 2025

ironAiken2 requested review from agatha197 and yomybaby January 20, 2025 05:52

ironAiken2 marked this pull request as ready for review January 20, 2025 05:52

yomybaby mentioned this pull request Jan 20, 2025

Link the VFolder name to open the Folder Explorer in Session detail Panel #3051

Open

ironAiken2 changed the title ~~feat(FR-249): open folder explorer from session detail panel using vfolder_nodes~~ feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes Jan 20, 2025

agatha197 approved these changes Jan 21, 2025

View reviewed changes

ironAiken2 force-pushed the feat/open-folder-explorer-from-session-detail-panel branch from 8468084 to 61191e3 Compare January 23, 2025 09:54

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 25dc6ea to 2027255 Compare January 23, 2025 10:00

ironAiken2 marked this pull request as draft January 24, 2025 06:24

ironAiken2 marked this pull request as ready for review January 24, 2025 06:49

ironAiken2 force-pushed the feat/open-folder-explorer-from-session-detail-panel branch from 61191e3 to b9992c8 Compare January 24, 2025 06:49

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch 2 times, most recently from bd937d4 to 4159954 Compare January 24, 2025 07:14

yomybaby changed the base branch from feat/open-folder-explorer-from-session-detail-panel to graphite-base/3052 January 24, 2025 10:02

yomybaby force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 4159954 to 1b61f9a Compare January 24, 2025 10:04

yomybaby force-pushed the graphite-base/3052 branch from b9992c8 to 9c53670 Compare January 24, 2025 10:04

yomybaby changed the base branch from graphite-base/3052 to main January 24, 2025 10:05

yomybaby force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 1b61f9a to 6510b79 Compare January 24, 2025 10:05

yomybaby requested changes Jan 24, 2025

View reviewed changes

src/lib/backend.ai-client-esm.ts Outdated Show resolved Hide resolved

react/src/components/SessionDetailContent.tsx Outdated Show resolved Hide resolved

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 6510b79 to e258119 Compare January 31, 2025 01:44

ironAiken2 requested review from agatha197 and yomybaby January 31, 2025 03:44

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from e258119 to 9b58324 Compare February 7, 2025 08:30

github-actions bot added size:M and removed size:L labels Feb 7, 2025

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch 3 times, most recently from 9f5ab1f to 62893ab Compare February 20, 2025 08:02

yomybaby force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 62893ab to 4f446ed Compare February 21, 2025 03:14

yomybaby requested changes Feb 21, 2025

View reviewed changes

yomybaby changed the title ~~feat(FR-247, FR-249): open folder explorer from session detail panel using vfolder_nodes~~ feat(FR-249): open folder explorer from session detail panel using vfolder_nodes Feb 21, 2025

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 4f446ed to 9ee4ca6 Compare February 24, 2025 02:08

ironAiken2 requested a review from yomybaby February 24, 2025 02:10

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch 3 times, most recently from 83fb051 to 7777f0b Compare February 25, 2025 08:02

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 7777f0b to 2fc7162 Compare March 4, 2025 02:03

yomybaby requested changes Mar 4, 2025

View reviewed changes

ironAiken2 force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 2fc7162 to 324023f Compare March 4, 2025 04:00

ironAiken2 requested a review from yomybaby March 4, 2025 04:02

yomybaby approved these changes Mar 4, 2025

View reviewed changes

graphite-app bot force-pushed the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch from 324023f to 2e8f90c Compare March 4, 2025 08:54

graphite-app bot merged commit 2e8f90c into main Mar 4, 2025
5 of 6 checks passed

graphite-app bot deleted the feat/open-folder-explorer-in-session-detail-panel-using-vfolder-nodes branch March 4, 2025 08:55

github-pages bot temporarily deployed to github-pages March 4, 2025 08:55 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

feat(FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

ironAiken2 commented Jan 20, 2025 •

edited

Loading

ironAiken2 commented Jan 20, 2025 •

edited

Loading

agatha197 left a comment

github-actions bot commented Jan 24, 2025 •

edited

Loading

yomybaby left a comment

ironAiken2 commented Feb 24, 2025

yomybaby left a comment

ironAiken2 commented Mar 4, 2025

yomybaby left a comment

graphite-app bot commented Mar 4, 2025 •

edited

Loading

feat(FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

feat(FR-249): open folder explorer from session detail panel using vfolder_nodes #3052

Conversation

ironAiken2 commented Jan 20, 2025 • edited Loading

ironAiken2 commented Jan 20, 2025 • edited Loading

How to use the Graphite Merge Queue

agatha197 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 24, 2025 • edited Loading

Coverage report for ./react

yomybaby left a comment

Choose a reason for hiding this comment

ironAiken2 commented Feb 24, 2025

yomybaby left a comment

Choose a reason for hiding this comment

ironAiken2 commented Mar 4, 2025

yomybaby left a comment

Choose a reason for hiding this comment

graphite-app bot commented Mar 4, 2025 • edited Loading

Merge activity

ironAiken2 commented Jan 20, 2025 •

edited

Loading

ironAiken2 commented Jan 20, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

Coverage report for `./react`

graphite-app bot commented Mar 4, 2025 •

edited

Loading