Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia): move event type to common, define xid/sxid event level in the list #297

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 15, 2025

No description provided.

@gyuho gyuho self-assigned this Jan 15, 2025
@gyuho gyuho force-pushed the xid-sxid-with-component-event-type branch from d3d2b00 to 2f53f61 Compare January 18, 2025 07:49
@gyuho gyuho added this to the v0.4.0 milestone Jan 19, 2025
@gyuho gyuho force-pushed the xid-sxid-with-component-event-type branch 3 times, most recently from 5af59be to 3fc50db Compare January 21, 2025 10:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (88e73d8) to head (1f3f99a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../accelerator/nvidia/error/sxid/component_output.go 0.00% 8 Missing ⚠️
...nts/accelerator/nvidia/error-xid-sxid/component.go 0.00% 2 Missing ⚠️
components/accelerator/nvidia/query/sxid/sxid.go 50.00% 1 Missing and 1 partial ⚠️
components/accelerator/nvidia/query/xid/xid.go 50.00% 1 Missing and 1 partial ⚠️
...s/accelerator/nvidia/error/xid/component_output.go 91.66% 1 Missing ⚠️
...onents/accelerator/nvidia/hw-slowdown/component.go 0.00% 1 Missing ⚠️
components/accelerator/nvidia/nccl/component.go 0.00% 1 Missing ⚠️
components/accelerator/nvidia/peermem/component.go 0.00% 1 Missing ⚠️
components/cpu/component.go 0.00% 1 Missing ⚠️
components/fd/component.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   21.04%   21.07%   +0.02%     
==========================================
  Files         299      298       -1     
  Lines       26872    26750     -122     
==========================================
- Hits         5655     5637      -18     
+ Misses      20551    20443     -108     
- Partials      666      670       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gyuho gyuho force-pushed the xid-sxid-with-component-event-type branch 2 times, most recently from 62b34ac to 346ca89 Compare January 21, 2025 14:29
@gyuho gyuho force-pushed the xid-sxid-with-component-event-type branch from 346ca89 to 2a17c78 Compare January 21, 2025 15:20
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho merged commit a453982 into main Jan 22, 2025
6 checks passed
@gyuho gyuho deleted the xid-sxid-with-component-event-type branch January 22, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants