Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia): move event type to common, define xid/sxid event level in the list #297

Merged
merged 3 commits into from
Jan 22, 2025

fix

1f3f99a
Select commit
Loading
Failed to load commit list.
Merged

feat(nvidia): move event type to common, define xid/sxid event level in the list #297

fix
1f3f99a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 1s

21.07% (+0.02%) compared to 88e73d8

View this Pull Request on Codecov

21.07% (+0.02%) compared to 88e73d8

Details

Codecov Report

Attention: Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.

Project coverage is 21.07%. Comparing base (88e73d8) to head (1f3f99a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../accelerator/nvidia/error/sxid/component_output.go 0.00% 8 Missing ⚠️
...nts/accelerator/nvidia/error-xid-sxid/component.go 0.00% 2 Missing ⚠️
components/accelerator/nvidia/query/sxid/sxid.go 50.00% 1 Missing and 1 partial ⚠️
components/accelerator/nvidia/query/xid/xid.go 50.00% 1 Missing and 1 partial ⚠️
...s/accelerator/nvidia/error/xid/component_output.go 91.66% 1 Missing ⚠️
...onents/accelerator/nvidia/hw-slowdown/component.go 0.00% 1 Missing ⚠️
components/accelerator/nvidia/nccl/component.go 0.00% 1 Missing ⚠️
components/accelerator/nvidia/peermem/component.go 0.00% 1 Missing ⚠️
components/cpu/component.go 0.00% 1 Missing ⚠️
components/fd/component.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   21.04%   21.07%   +0.02%     
==========================================
  Files         299      298       -1     
  Lines       26872    26750     -122     
==========================================
- Hits         5655     5637      -18     
+ Misses      20551    20443     -108     
- Partials      666      670       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov