Enable all typescript-eslint recommended-type-checked rules #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bunch of good rules there and we already follow almost all of them. Making the backend code compatible with these rules uncovered some potential issues in our code already.
jstasiak
requested review from
a team,
rbruggem,
raguiar9080,
charcarr,
0bex0 and
jasharifestina
jstasiak
changed the title
raguiar9080
approved these changes
Aug 22, 2024
jstasiak
commented
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of good rules there and we already follow almost all of them.
Making the backend code compatible with these rules uncovered some potential issues in our code already.
The backend code can be linted with these rules with only small changes required (there are already PRs for those).