Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all typescript-eslint recommended-type-checked rules #4

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Enable all typescript-eslint recommended-type-checked rules #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
687fe04
Enaboe all typescript-eslint recommended-type-checked rules
jstasiak Aug 22, 2024
a5d86cc
Merge branch 'master' into ts-recommended
jstasiak Aug 22, 2024
ce764d5
Update index.js
jstasiak Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ module.exports = {
browser: true,
es2021: true,
},
extends: ['standard', 'prettier', 'eslint:recommended'],
extends: [
'standard',
'prettier',
'eslint:recommended',
'plugin:@typescript-eslint/recommended-type-checked',
],
parser: '@typescript-eslint/parser',
parserOptions: {
ecmaVersion: 12,
Expand Down Expand Up @@ -44,5 +49,35 @@ module.exports = {
// dependency (which I'd like to do ASAP, it pulls eslint-plugin-import and so many
// transitive dependencies that we don't even use.
'no-void': 'off',

/*
@typescript-eslint/recommended-type-checked exceptions

To be determined if we want to keep these rules disabled long-term, at least some
of these look useful, we just need to configure them so they don't generate so many
false positives.
*/

'@typescript-eslint/require-await': 'off',
'@typescript-eslint/unbound-method': 'off',

// Being able to use and interact with "any" values
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-argument': 'off',

// Generates a lof of false positives when it doesn't always understand when a value
// can be safely used in a string context. We can try to configure this behavior.
'@typescript-eslint/no-base-to-string': 'off',

// Prevents using Big (among others) in string templates
'@typescript-eslint/restrict-template-expressions': 'off',

/*
End of @typescript-eslint/recommended-type-checked exceptions
*/
},
}
Loading