Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make environments roundtrip as Z data #1200

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: make environments roundtrip as Z data #1200

merged 1 commit into from
Mar 7, 2024

Conversation

arthurpaulino
Copy link
Contributor

PR #1183 didn't include the logic for environments when collecting the children of pointers. We didn't see the error because our tests weren't checking for environment roundtrip through Z data.

Here we fix that bug and also enhance the tests to avoid future regressions.

@arthurpaulino
fix: make environments roundtrip as Z data
0d68185 
PR #1183 didn't include the logic for environments when collecting
the children of pointers. We didn't see the error because our tests
weren't checking for environment roundtrip through Z data.

Here we fix that bug and also enhance the tests to avoid future
regressions.
@arthurpaulino arthurpaulino requested review from a team as code owners March 7, 2024 02:12
@arthurpaulino arthurpaulino enabled auto-merge March 7, 2024 02:12
@arthurpaulino arthurpaulino added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 7ad45e6 Mar 7, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/fix-nightly branch March 7, 2024 03:32
arthurpaulino added a commit that referenced this pull request Mar 7, 2024
@arthurpaulino
chore: use RawPtr::Env to signal raw pointers for environments
816eaa5 
It's safer to use a new variant `RawPtr::Env` to signal raw pointers
for environments than relying solely on tag checks. This would
probably have avoided the bug introduced in #1183, whose fix was
implemented in #1200
This was referenced Mar 7, 2024
Closed
Closed
arthurpaulino added a commit that referenced this pull request Mar 7, 2024
@arthurpaulino
chore: use RawPtr::Env to signal raw pointers for environments
f1be69f 
It's safer to use a new variant `RawPtr::Env` to signal raw pointers
for environments than relying solely on tag checks. This would
probably have avoided the bug introduced in #1183, whose fix was
implemented in #1200
arthurpaulino added a commit that referenced this pull request Mar 7, 2024
@arthurpaulino
chore: use RawPtr::Env to signal raw pointers for environments
94c18a8 
It's safer to use a new variant `RawPtr::Env` to signal raw pointers
for environments than relying solely on tag checks. This would
probably have avoided the bug introduced in #1183, whose fix was
implemented in #1200
arthurpaulino added a commit that referenced this pull request Mar 8, 2024
@arthurpaulino
chore: use RawPtr::Env to signal raw pointers for environments
f4d3a5c 
It's safer to use a new variant `RawPtr::Env` to signal raw pointers
for environments than relying solely on tag checks. This would
probably have avoided the bug introduced in #1183, whose fix was
implemented in #1200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurpaulino @huitseeker