Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic crash dump retrieval #921

Merged
merged 23 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceSideConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set(DEPTHAI_DEVICE_SIDE_MATURITY "snapshot")

# "full commit hash of device side binary"
set(DEPTHAI_DEVICE_SIDE_COMMIT "3181f130742ed4f18341970a936afbdcfeaddbc9")
set(DEPTHAI_DEVICE_SIDE_COMMIT "b4fe4123e942f89321e21588a5518a9443b7e0cc")

# "version if applicable"
set(DEPTHAI_DEVICE_SIDE_VERSION "")
8 changes: 6 additions & 2 deletions include/depthai/device/DeviceBase.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ class DeviceBase {
*
* @param devInfo DeviceInfo which specifies which device to connect to
*/
DeviceBase(const DeviceInfo& devInfo);
explicit DeviceBase(const DeviceInfo& devInfo);

/**
* Connects to any available device with a DEFAULT_SEARCH_TIME timeout.
Expand Down Expand Up @@ -376,8 +376,9 @@ class DeviceBase {
* @param config Config with which the device will be booted with
* @param devInfo DeviceInfo which specifies which device to connect to
* @param pathToCmd Path to custom device firmware
* @param dumpOnly If true only the minimal connection is established to retrieve the crash dump
*/
DeviceBase(Config config, const DeviceInfo& devInfo, const dai::Path& pathToCmd);
DeviceBase(Config config, const DeviceInfo& devInfo, const dai::Path& pathToCmd, bool dumpOnly = false);

/**
* Device destructor
Expand Down Expand Up @@ -940,5 +941,8 @@ class DeviceBase {

// Device config
Config config;

dai::Path firmwarePath;
bool dumpOnly = false;
};
} // namespace dai
2 changes: 1 addition & 1 deletion shared/depthai-shared
Loading
Loading