Mock isp #951
Closed
Mock isp #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @asahtik for replay |
moratom
reviewed
Jan 21, 2024
There was a problem hiding this comment.
Thanks Filip!
Was the non blocking behavior of the input queues here intentional?
I'm thinking if it would be better to have them blocking by default to (by default) always replay all frames, when replaying will be implemented.
Otherwise LGTM to merge either way after we add some test coverage.
|
Merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and uncommented Camera node mockIsp, added mockIsp to ColorCamera and MonoCamera nodes.