Updating cross_section_pts() function to remove and reevaluate "flat" Z value cross sections #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s(), that cross network flowlines more than 1 time
…ted a function for extending linestring geometries from both ends by a certain percent of the original linestring geometries length
…ctions to modularize the code and make a check for any cross sections with flat Z values and makes an attempt to extend those cross sections and re extract Z values
…to new code and making a secondary v1 version of the function which is the old version of the code
…tion_pts() only remove flat cross sections, i.e. cross sections with all identical Z values
… original DEM values along the cross section lines, and the second rectify_flat_cs() function that will update or remove cross sections with flat cross sections (cross sections with all the same Z values)
…heck when seeing whether to extend a cross section or not
… change the geometry column to geom, at the end of rectify_cs_pts()
…or plotting cross section point Z values, and updated classify_pts() function to use cs_lengthm column instead of cs_widths column and added a point_type column that replicates the class column to eventually replace class column in future
…a given set of cross section points, WIP on applying this within rectify_flat_cs() function
…ectify_flat_cs() function with new version and temporarily keeping old version under the name rectify_flat_cs_v1(), will be deleted in future
… cross section points
…sines angles from a specified point within a set of cs points, bug fix on get_point_type_counts() that was double counting point types when a point type was missing from a cross section
…proving extracted cross section pts, created utils.R for general utility functions, added functions for adding bank validity and relief attributes to classified cross section pts, added bank and relief attributes to the output of the classify_points() function
…rnings when building pkg, bumped version, added a dontrun on move_geometry_to_last() roxygen example decorator
…at the beginning of the function
…ged function use point_type instead of class col
… error if there is valid_banks or has_relief values of NA, instead these transects get set aside and added back to the output
… DEM cro0ss ssections
…as into cross section DEM points, bumped version
…ransects to reach fema bounds
…n boundaries (used for FEMA floodplain extensions)
…n roxygen comments
… made it use st_length() after the extensions to recalc length
… memory issues and forced more simplification, changed calls to is_valid_transect() to use just the current hy_id and flowline instead of entire network
…polygons() and also added a removal of self intersections after extending the transects
…educed number of copies made in processing
…performs intersects check on each new_line, big performance boost from this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross_section_pts()function to check for any cross sections with Z values that are all the same across a cross section and thus give a "flat" cross sectionDS_storeto ``.gitignore`cross_section_pts()has ais_extendedflag that indicates if the original transect line was extended to find relevant Z values (is_extended = TRUE)