fix: Adapt root prefix determination #3782
Merged
+133
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
commented
Jan 29, 2025
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/root-prefix-determination
branch
from
317b222 to
6048c2a
Compare
JohanMabille
approved these changes
Jan 29, 2025
Klaim
reviewed
Jan 29, 2025
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Klaim <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/root-prefix-determination
branch
from
110905c to
acf4828
Compare
jjerphan
commented
Jan 29, 2025
Comment on lines
+1
to
+6
| if [ -z "${MAMBA_ROOT_PREFIX}" ]; then | ||
| echo "WARNING: MAMBA_ROOT_PREFIX is not set." | ||
| echo "WARNING: Please set `MAMBA_ROOT_PREFIX` to the root of your installation." | ||
| echo "WARNING: For now continuing with `MAMBA_ROOT_PREFIX` set to `@CMAKE_INSTALL_PREFIX@`." | ||
| export MAMBA_ROOT_PREFIX="@CMAKE_INSTALL_PREFIX@" | ||
| fi |
There was a problem hiding this comment.
What do people think of this?
There was a problem hiding this comment.
I don't have any strong opinion about this. We can still revert it later if people are annoyed by the warning.
Klaim
reviewed
Jan 29, 2025
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Klaim <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/root-prefix-determination
branch
from
d4e642c to
de142a7
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/root-prefix-determination
branch
from
08480bd to
457efb7
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
force-pushed
the
fix/root-prefix-determination
branch
from
457efb7 to
a7062c2
Compare
JohanMabille
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See conda/conda-libmamba-solver#610 (comment).