-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adapt root prefix determination #3782
Merged
JohanMabille
merged 15 commits into
mamba-org:main
from
jjerphan:fix/root-prefix-determination
Jan 30, 2025
+133
−44
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4b6de6c
Do not reset `MAMBA_ROOT_PREFIX` if it is already set
jjerphan ae643dc
Search for the root prefix from the executable
jjerphan 1a297ca
Add a dedicated util function identifying the root prefix
jjerphan 8fafadd
Add utility function to find the path of libmamba
jjerphan f6083e5
Use libmamba's path instead of the executable's
jjerphan 6048c2a
Rename and constify some l-values
jjerphan 7accbe5
Address review comments
jjerphan 105e8a9
Remove old unused variable
jjerphan acf4828
Warn in profile script if MAMBA_ROOT_PREFIX is not set
jjerphan 1dc7224
Support unicode
jjerphan de142a7
Use `validate_existing_root_prefix`
jjerphan d5a91cc
Improve handling of GetModuleFileNameW
jjerphan fd9561b
Handle GetModuleHandleExW's failure
jjerphan 9ab42d9
Handle dladdr's failure
jjerphan a7062c2
Resize instead of reserve
jjerphan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do people think of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any strong opinion about this. We can still revert it later if people are annoyed by the warning.