Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'GRANT DATABASE' to rbac #988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hal-eisen-MG
Copy link
Contributor

@hal-eisen-MG hal-eisen-MG commented Sep 12, 2024

Description

Updated the role-based-access-control.mdx based on a thread in Discord. Added a link in the main table for the DATABASE privilege which points to the new multi-tenancy page. Added "GRANT DATABASE" to several of the examples.

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
(especially necessary if the PR is related to a release)

Closes:
(paste the link to the issue it closes)

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 1:14am

@hal-eisen-MG hal-eisen-MG added the priority: low (improvements) An idea how the representation of knowledge on a certain page could be improved label Sep 12, 2024
@hal-eisen-MG hal-eisen-MG linked an issue Sep 12, 2024 that may be closed by this pull request
Copy link
Contributor

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this is also an issue that inspired me to open this issue:
https://memgraph.com/docs/database-management/authentication-and-authorization/role-based-access-control#manage-all-privileges-at-once

After this command:

GRANT ALL PRIVILEGES TO user;

User should have all permission, you still need to run these (next to the command above) :

GRANT CREATE_DELETE ON LABELS * TO user;
GRANT CREATE_DELETE ON EDGE_TYPES * TO user;

To be able to create a node or relationship, while the docs suggest otherwise.

@katarinasupe
Copy link
Contributor

@antejavor can you review/update this PR by the end of next week? (Nov 22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low (improvements) An idea how the representation of knowledge on a certain page could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify docs on Role based access control
3 participants