fix: avoid failure when no special pip deps and better exit #1228
+13
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
force-pushed
the
fix-build-venv
branch
2 times, most recently
from
de8c113 to
075895d
Compare
leseb
changed the title
When building providers in a virtual environment or containers, special pip dependencies may not always be provided (e.g., for Ollama). The check should only fail if the required number of arguments is missing. Currently, two arguments are mandatory: 1. Environment name 2. Pip dependencies Additionally, return statements were replaced with sys.exit(1) in error conditions to ensure immediate termination on critical failures. Error handling in the stack build process was also improved to guarantee the program exits with status 1 when facing configuration issues or build failures. Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
fix-build-venv
branch
from
075895d to
bc89d8b
Compare
This was referenced Feb 24, 2025
luis5tb
reviewed
Feb 24, 2025
| @@ -32,7 +32,7 @@ container_base="$3" | |||
| build_file_path="$4" | |||
| host_build_dir="$5" | |||
| pip_dependencies="$6" | |||
| special_pip_deps="$7" | |||
| special_pip_deps="${7:-}" | |||
There was a problem hiding this comment.
in build_conda_env.sh/ build_venv.sh this is moved to before the "set -euo pipefail". Both options work, but better to align them. So, perhaps better to mimic the option in there (or change the other 2 to be like this one
|
do these overlap at all #1233? |
Yeah, I think it'll be great to have the renaming done after this current one is merged? What do you think? |
cdoern
approved these changes
Feb 24, 2025
terrytangyuan
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When building providers in a virtual environment or containers, special
pip dependencies may not always be provided (e.g., for Ollama). The
check should only fail if the required number of arguments is missing.
Currently, two arguments are mandatory:
Additionally, return statements were replaced with sys.exit(1) in error
conditions to ensure immediate termination on critical failures. Error
handling in the stack build process was also improved to guarantee the
program exits with status 1 when facing configuration issues or build
failures.
Signed-off-by: Sébastien Han [email protected]
Test Plan
This command shouldn't fail: