Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build_venv expects an extra argument #1233

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Feb 24, 2025

What does this PR do?

currently, build_venv.sh expects a distribution_type as the first argument but the only things ever passed are:

  1. image name
  2. pip dependencies

so distribution_type is never passed in meaning the script errors when calling something like:

llama stack build --image-type venv --template ollama --image-name test

before output:

llama stack build --image-type venv --template ollama --image-name venv-test
Usage: /Users/charliedoern/projects/Documents/llama-stack/llama_stack/distribution/build_venv.sh <distribution_type> <env_name> <pip_dependencies> [<special_pip_deps>]
Example: /Users/charliedoern/projects/Documents/llama-stack/llama_stack/distribution/build_venv.sh <distribution_type> mybuild ./my-stack-build.yaml 'numpy pandas scipy'
Failed to build target venv-test with return code 1
Run config path is empty

after:

llama stack build --image-type venv --template ollama --image-name venv-test
Environment 'venv-test' already exists, re-using it.
Using virtual environment venv-test
Using CPython 3.13.0 interpreter at: /opt/homebrew/opt/[email protected]/bin/python3.13
Creating virtual environment at: venv-test
Activate with: source venv-test/bin/activate
Using Python 3.13.0 environment at: venv-test
Resolved 55 packages in 640ms
      Built fire==0.7.0
Prepared 54 packages in 1.14s
Installed 55 packages in 82ms
 + annotated-types==0.7.0

Test Plan

ran locally with output above

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 24, 2025
@cdoern
Copy link
Contributor Author

cdoern commented Feb 24, 2025

this could be something I am misunderstanding but I don't see how that arg is ever currently used in the way the code is written

@leseb
Copy link
Contributor

leseb commented Feb 24, 2025

I think we should have #1228 merged first and then use this one for the usage examples. Thanks!

@cdoern
Copy link
Contributor Author

cdoern commented Feb 24, 2025

yup, makes sense to me @leseb !

currently, build_venv.sh expects a `distribution_type` as the first argument but the only things ever passed are:

1. image name
2. pip dependencies

so distribution_type is never passed in meaning the script errors when calling something like:

`llama stack build --image-type venv --template ollama --image-name test`

Signed-off-by: Charlie Doern <[email protected]>
@cdoern
Copy link
Contributor Author

cdoern commented Feb 24, 2025

@leseb rebased ✔️

@ashwinb ashwinb merged commit 9b130f9 into meta-llama:main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants