Support for named URLs with parameters #33
Conversation
It is now possible to pass names of parametrized URLs to the STRONGHOLD_PUBLIC_NAMED_URLS setting. Previously it was only possible to use names of URLs that didn't capture any parameters. This commit should also have a positive impact on speed.
The "resolver_match" is not accessible in the CI testing environment
|
This feature requires Django 1.5 or newer. |
|
I like this, but do you mean 1.6 or newer? I looked at the builds and it looks like before you changed fixed the symptom of the broken test, it was breaking in < 1.6. |
|
No, according to the documentation this should work in Django 1.5. I will add tests that explicitly check this functionality and we will see. |
|
Luckily the documentation is correct :) This works both in Django 1.5 and 1.6. I had to add the additional check in cdb3979, because when request happens outside of the usual "url pattern recognition - request - response" cycle (like when you use RequestFactory in tests) Django 1.5 does not set the |
|
Just so you know Im still looking at this, will be looking to get it merged this weekend. |
|
Just to let you know, had some stuff that has got into the way of me doing any work on this. I am circling around on this again now. Want to keep 1.4 compat until Django stops issuing updates for Django 1.4, so I will likely reimplement these changes with a check for Django Version. |
|
Again :) I am circling around on this again, looks like 1.7 is coming out soon, which means Django will be dropping support for 1.4, and I will likely drop support for 1.4 for new features as well. So I will roll out your PR unchanged, upon release of 1.7. |
|
Sounds great :) Thank you for keeping me updated! |
|
No problem :) Been feeling bad this has been just sitting there for so long! |
|
What's the current status on this? :) |
|
Hey, Thanks for checking in on this! I am coming to this during the week or this weekend. Hoping to tackle this ticket and this one #38 . |
|
Cool :) |
It is now possible to pass names of parametrized URLs to
the STRONGHOLD_PUBLIC_NAMED_URLS setting.
Previously it was only possible to use names of URLs that didn't
capture any parameters.
This commit should also have a positive impact on speed.