Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CDPATH in terminal suggest #239406

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Support CDPATH in terminal suggest #239406

merged 6 commits into from
Feb 3, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 1, 2025

Fixes #239401

Given CDPATH=c:\Github\xterm.js:

image

When the "relative" setting is used:

image

The reason it's absolute by default is to provide a consistent experience out of the box that maximizes compatibility.

This seems like it'll be quite a powerful feature. Something really nice about it is that users who use already use CDPATH will see it light up and the entries will be much more discoverable than before:

image

@Tyriar Tyriar added this to the February 2025 milestone Feb 1, 2025
@Tyriar Tyriar requested a review from meganrogge February 1, 2025 16:08
@Tyriar Tyriar self-assigned this Feb 1, 2025
@Tyriar Tyriar force-pushed the tyriar/239401_cdpath branch from 682456b to b8fb79b Compare February 3, 2025 12:19
@Tyriar Tyriar force-pushed the tyriar/239401_cdpath branch from b8fb79b to beb0595 Compare February 3, 2025 12:49
@Tyriar Tyriar merged commit 3de8db4 into main Feb 3, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/239401_cdpath branch February 3, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal suggest: Support $CDPATH completions
2 participants