Adding TRANSMEMBRANE and TOPOLOGICAL DOMAIN to protein types #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lay in protein metadata etc.
ielis
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
The PR looks OK, of course we must add the missing feature types.
However, we should also re-consider if defining FeatureType as an enum is actually justified. Perhaps we should change it to a str? This would affect one predicate (VariantPredicates.protein_feature_type()) and otherwise probably not too much other stuff.
Let's merge this PR and re-evaluate if a need for a new protein FeatureType arises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to display in the protein graphic.
@ielis I am not sure we want to crash if there is an unrecognized domain. Maybe it is better to just call anything we do not recognized "Region" and to emit a warning with a request for feedback? I am pretty sure we did not get all possible domains and I have not been able to find a complete list.