Skip to content

Commit

Permalink
Bug fix: Synonym Sync: Remove recapitalization of acronyms (#724)
Browse files Browse the repository at this point in the history
Bug fix: Synonym Sync: Recapitalization of acronyms
- Fixed bug where this operation was being done for -updated and -confirmed, but it should only be done for -added.
- Bug fix: I don't think we should have ever had this in the first place. I don't see that it actually fixes anything; only should cause bugs.
  • Loading branch information
joeflack4 authored Jan 9, 2025
1 parent cf1cda5 commit b0edf7a
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions src/scripts/sync_synonym.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,6 @@ def _common_operations(

# Format
if not df_is_combined:
# - Acronyms: Use source case
# This operation prevents capitalization from being lost, as sometimes Mondo has used lowercase. However,
# ignore cases where 'synonym_case_source' is multi-value.
df['synonym'] = df.apply(lambda row: row['synonym_case_source']
if MONDO_ABBREV_URI in row['synonym_type']
and not (bool(row['synonym_case_mondo_is_many']) if 'synonym_case_mondo_is_many' in row else False)
else row['synonym'], axis=1)
# - Add ROBOT columns for each synonym scope
synonym_scopes = ['exact', 'broad', 'narrow', 'related']
for scope in synonym_scopes:
Expand Down

0 comments on commit b0edf7a

Please sign in to comment.