Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Synonym Sync: Remove recapitalization of acronyms #724

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Bug fix: Synonym Sync: Remove recapitalization of acronyms #724

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8c0679
Bug fix: Synonym Sync: Recapitalization of acronyms
joeflack4 Dec 17, 2024
caf9309
Bug fix: Synonym Sync: Recapitalization of acronyms
joeflack4 Dec 17, 2024
d6a7b9a
Merge branch 'bugfix-syn-sync-dupe-rows-684' into bugfix-syn-sync-acr…
joeflack4 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/scripts/sync_synonym.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,6 @@ def _common_operations(

# Format
if not df_is_combined:
# - Acronyms: Use source case
# This operation prevents capitalization from being lost, as sometimes Mondo has used lowercase. However,
# ignore cases where 'synonym_case_source' is multi-value.
df['synonym'] = df.apply(lambda row: row['synonym_case_source']
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
if MONDO_ABBREV_URI in row['synonym_type']
and not (bool(row['synonym_case_mondo_is_many']) if 'synonym_case_mondo_is_many' in row else False)
else row['synonym'], axis=1)
# - Add ROBOT columns for each synonym scope
synonym_scopes = ['exact', 'broad', 'narrow', 'related']
for scope in synonym_scopes:
Expand Down