Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Subclass Sync: Comments & Minor Refactor - build #737

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

- Update: _convert_edge_namespace(): (i) removed unused optional param, (ii) improved documentation.
- Update: Improved some comments explaining some confusingly named variables.
- Update: Removed 'verbose' param from _get_direct_scr_rels(). This function ran fast, and there was no need to print out the time taken.
- Update: Misc codestyle refactors
- Update: Case 5 code: Was redundant with some other code. Made DRY.
@joeflack4 joeflack4 self-assigned this Dec 21, 2024
@joeflack4 joeflack4 marked this pull request as draft December 21, 2024 03:58
@joeflack4 joeflack4 changed the title DO NOT MERGE : Subclass Sync: Comments & Minor Refactor - build DO NOT MERGE: Subclass Sync: Comments & Minor Refactor - build Dec 21, 2024
@joeflack4 joeflack4 added the build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes label Dec 21, 2024
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from subclass-sync-comments-and-minor-refactor to develop January 11, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Mostly for build PRs: when changes only to data files post `build-mondo-ingest`; no code changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant