DO NOT MERGE: Address qc-duplicate-exact-synonym-no-abbrev failures in mondo - build
#755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filters cases where there are multiple Mondo terms with the same exactSynonym, and instead puts them into a special curation TSV. - Add: reports/review-qc-duplicate-exact-synonym-no-abbrev.tsv - Add/Update: Make goals & Python scripting to filter files & create that TSV.
- Update: Handle Mondo -unconfirmed cases too: Cases where the synonym sync finds no trace of the synonym in the source, but since we have not yet - Update: Removed -confirmed deduping. This wasn't the correct way to handle checking against synonyms that already exist in Mondo, and -confirmed does not introduce duplication anyway. It doesn't add synonyms; only adds evidence for existing ones.
- Remove some temporary code
- Update: Handling cases now where a new exactSynonym coming in through the sync is equivalent to a label that exists on another Mondo term.
- codestyle update
9 tasks
joeflack4
added
the
build
joeflack4
force-pushed
the
qc-duplicate-exact-synonym-no-abbrev--build
branch
from
145c019 to
7f159e3
Compare
joeflack4
force-pushed
the
qc-duplicate-exact-synonym-no-abbrev--build
branch
from
7f159e3 to
016ff3e
Compare
joeflack4
commented
Jan 17, 2025
- remove temp file
joeflack4
commented
Jan 23, 2025
There was a problem hiding this comment.
LGTM! Also what I wrote in the mini-build, confirmed working as attended via QC check in mondo:
Base automatically changed from
qc-duplicate-exact-synonym-no-abbrev
to
develop
February 5, 2025 02:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for:
qc-duplicate-exact-synonym-no-abbrevfailures inmondo#751