Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several user requests #216

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Several user requests #216

merged 3 commits into from
Jan 29, 2025

Conversation

katiermullen
Copy link
Collaborator

Closes several issues:

Closes #215
Closes #212
Closes #107
Closes #205
Closes #203
Closes #202
Closes #175
Closes #174
Closes #173
Closes #201
Closes #182

Closes several issues:

Closes #215
Closes #212
Closes #107
Closes #205
Closes #203
Closes #202
Closes #175
Closes #174
Closes #173
Closes #201
Closes #182
@katiermullen katiermullen self-assigned this Jan 25, 2025
-trim white spaces from DAD-IS breed-country spreadsheet
-remove SC axiom for obsoleted term
@katiermullen
Copy link
Collaborator Author

@sabrinatoro could you please review at your convenience? Thank you!!!

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiermullen some changes requested.
We can discuss this during our 1:1 if you have questions

  • VBO:0100159 ('obsolete Me-kong Bobtail (Cat)'): use "replaced by" instead of "consider"
  • remove "source" and "contributor" from the obsoleted terms (this should be transferred to the new term) this should be for
    • VBO:0000169 ('obsolete Busha (Cattle)')
    • VBO:0000408 ('obsolete Tiroler Grauvieh (Cattle)')
    • VBO:0000407 ('obsolete Tirolean gray cattle (Cattle)')
    • VBO:0000844 ('obsolete Tennessee Fainting (Goat)')
    • VBO:0000985 ('obsolete Holstein (Horse)')
    • VBO:0001072 ('obsolete Slovak Warmblood Horse (Horse)')
  • we should run a normalization step
  • VBO:0010423 ('obsolete Bavarian, United Kingdom of Great Britain and Northern Ireland (Horse)') All annotations (including has_domestication status, description of origin, source, contributor) should be removed and added to the merged term (which was already done)

src/ontology/components/catbreeds.owl Show resolved Hide resolved
@katiermullen
Copy link
Collaborator Author

@sabrinatoro thank you for your review. Everything made perfect sense and I have updated the spreadsheets with the requested changes. Before I push the PR can you please remind me how to run the normalization step?

Thank you!

update with requested changes.
@katiermullen
Copy link
Collaborator Author

@sabrinatoro could you please review this PR? I have updated it with the changes you requested. Thank you!

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this, Katie. It looks good.
Approving and merging

@sabrinatoro sabrinatoro merged commit f90ab61 into master Jan 29, 2025
1 check passed
@sabrinatoro sabrinatoro deleted the 250124-issues branch January 29, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment