FIX(plugins): Compilation with new unified header #6268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new header (as introduced via 2b35c0c) was missing a typedef and a utility macro for dealing with the versioned MumbleAPI struct. Furthermore, plugins that are only build in debug builds were still including the old (and now non-existing) headers.
Krzmbrzl
added
build
davidebeatrici
approved these changes
Nov 30, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new header (as introduced via
2b35c0c) was missing a typedef and a utility macro for dealing with the versioned MumbleAPI struct.
Furthermore, plugins that are only build in debug builds were still including the old (and now non-existing) headers.
Checks