Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Merge PR #6268: FIX(plugins): Compilation with new unified header" to 1.5.x #6271

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Backport "Merge PR #6268: FIX(plugins): Compilation with new unified header" to 1.5.x #6271

merged 1 commit into from
Dec 25, 2023

Conversation

Krzmbrzl
Copy link
Member

@Krzmbrzl Krzmbrzl commented Dec 1, 2023

Backport

This will backport the following commits from master to 1.5.x:

Questions ?

Please refer to the Backport tool documentation

@Krzmbrzl
FIX(plugins): Compilation with new unified header
429beb6 
The new header (as introduced via
2b35c0c) was missing a typedef and a
utility macro for dealing with the versioned MumbleAPI struct.

Furthermore, plugins that are only build in debug builds were still
including the old (and now non-existing) headers.

(cherry picked from commit 8a764cf)
@Krzmbrzl Krzmbrzl self-assigned this Dec 1, 2023
@Krzmbrzl Krzmbrzl mentioned this pull request Dec 1, 2023
Merged
1 task
@Krzmbrzl Krzmbrzl merged commit 46730f6 into 1.5.x Dec 25, 2023
20 checks passed
@Krzmbrzl Krzmbrzl deleted the backport/1.5.x/pr-6268 branch January 13, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Krzmbrzl Krzmbrzl

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Krzmbrzl