Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: err handling #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: err handling #2

wants to merge 4 commits into from
+2,450 −23

Conversation

hugocortes
Copy link
Contributor

  • fixes error emitting by checking emitErrs flag from extension
  • removes lodash dep
  • exposes on to allow message handling
  • adds tests to validate extension error handling

@hugocortes hugocortes mentioned this pull request Dec 27, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugocortes