fix: err handling

.eslintrc.js

@@ -10,9 +10,7 @@ module.exports = {
       ],
       "no-underscore-dangle": [
           "error",
-          {
-              "allow": ["_id"]
-          }
+          "never"
       ],
       "indent": [
           "error",

.gitignore

@@ -1 +1,2 @@
-node_modules/
+node_modules/
+.vscode/

README.md

@@ -22,3 +22,7 @@ Transporter.publish('message 1', function(){
 
 - [Google PubSub](https://github.com/myDevicesIoT/pubsub-transporter)
 - [RabbitMQ](https://github.com/myDevicesIoT/rabbit-transporter)
+
+### Testing
+
+Install all dependencies and use `npm test`

index.js

@@ -1,6 +1,5 @@
 const transporter = exports;
 
-
 transporter.Transport = require('./lib/transport').Transport;
 transporter.Publisher = require('./lib/publisher').Publisher;
 transporter.Redis = require('./lib/redis').Redis;
@@ -17,7 +16,8 @@ const methods = [
   'add',
   'remove',
   'handleExceptions',
-  'unhandleExceptions'
+  'unhandleExceptions',
+  'on'
 ];
 
 methods.forEach((method) => {

lib/publisher.js

@@ -107,8 +107,19 @@ Publisher.prototype.add = function func(transport, options, created) {
   return this;
 };
 
+Publisher.prototype.remove = function(transportName) {
+  if (!this.transports[transportName]) {
+    throw new Error(`Transport not attached: ${transportName}`);
+  }
+
+  delete this.transports[transportName];
+  this._names = Object.keys(this.transports);
+
+  return this;
+};
+
 Publisher.prototype._onError = function func(transport, err) {
-  if (this.emitErrs) {
+  if (transport.options && transport.options.emitErrs) {
     this.emit('error', err, transport);
   }
 };

lib/redis.js

@@ -1,19 +1,24 @@
-const _ = require('lodash');
 const util = require('util');
 const redis = require('redis');
 const { Transport } = require('./transport');
 
 const Redis = function func(options) {
   Transport.call(this, options);
 
-  this.options = options || {
+  this.options = Object.assign({
     host: 'localhost',
     port: 6379,
     password: null,
     channel: 'data-change'
-  };
+  }, options)
 
-  this.redisClient = redis.createClient(_.pick(this.options, ['host', 'port', 'password']));
+  let redisOpts = {
+    host: this.options.host,
+    port: this.options.port,
+    password: this.options.password
+  }
+
+  this.redisClient = redis.createClient(redisOpts);
 };
 
 util.inherits(Redis, Transport);
@@ -25,24 +30,17 @@ Redis.prototype.name = 'Redis';
 Redis.prototype.publish = function func(msg, callback) {
   const self = this;
   const str = JSON.stringify(msg);
-  let eventType = self.options.eventType;
-
-  if (msg.eventType) {
-    eventType = msg.eventType;
-  }
 
   const bus = msg.bus;
-  if (_.isNil(bus)) {
-    console.error('Transporter: No bus specified');
+  if (!bus) {
+    this.emit('error', new Error('No bus specified'));
     return callback();
   }
 
   return self.redisClient.GETBIT(msg.clientId, 0, (err, result) => {
     if (result === 0) {
-      //console.info('Transporter: No clients connected, not publishing message');
       return callback();
     }
-    //console.log(`Transporter: Pub to ${eventType} stream ${self.name} - ${str}`);
     return self.redisClient.publish(bus, str, () => callback());
   });
 };