Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7823] Update Docker scripts #7965

Merged
merged 5 commits into from
Oct 19, 2023
Merged

[#7823] Update Docker scripts #7965

merged 5 commits into from
Oct 19, 2023

Conversation

gbp
Copy link
Member

@gbp gbp commented Oct 19, 2023

Relevant issue(s)

Fixes #7823

What does this do?

  1. Minor changes to the scripts
  2. Ensure Docker environment works without manually performing commands.

gbp added 5 commits October 19, 2023 10:59
Reduce unnecessary output when commits or bundle are already up to date.
Remove exit on error (EG `set -e`) as we want to be able to catch errors
and handle them in sub-scripts.
Use uppercase variables.
Use named `--reset-data` argument. This is assumed true when data can't
be loaded from the database, otherwise it is false.
Remove external requests on setup. Eventually this will be removed when
we remove external requests from core but for now ensure a fresh Docker
environment works.

Fixes #7823
@gbp gbp marked this pull request as ready for review October 19, 2023 11:18
@gbp gbp merged commit 634e562 into develop Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No requests showing after install
1 participant