Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileUplink packet sequence repeat and CRC #1378 #3007

Merged
merged 7 commits into from
Nov 14, 2024

Updated UT to test that the first packet isn't erroneously marked as …

23fce43
Select commit
Loading
Failed to load commit list.
Merged

Fix FileUplink packet sequence repeat and CRC #1378 #3007

Updated UT to test that the first packet isn't erroneously marked as …
23fce43
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 7, 2024 in 4s

2 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 66 in Svc/FileUplink/Warnings.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Unchecked function argument Warning

This use of parameter sequenceIndex has not been checked.

Check notice on line 189 in Svc/FileUplink/FileUplink.cpp

See this annotation in the file changed.

Code scanning / CodeQL

Use of basic integral type Note

checkDuplicatedPacket uses the basic integral type bool rather than a typedef with size and signedness.