[FIXED] Default statistics handler of microservice had unnecessary check #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default handler was invoked with a request that was already checked to have a service associated. The handler was extracting the service (that was not needed) and had an incorrect check such as `if ((m == NULL) || (m == NULL))`. Resolves #833 Signed-off-by: Ivan Kozlovic <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 68.71% 70.47% +1.76%
==========================================
Files 39 47 +8
Lines 15207 15386 +179
Branches 3143 3154 +11
==========================================
+ Hits 10449 10843 +394
+ Misses 1700 1505 -195
+ Partials 3058 3038 -20 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2025
… microservice had unnecessary check (#837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default handler was invoked with a request that was already checked to have a service associated. The handler was extracting the service (that was not needed) and had an incorrect check such as
if ((m == NULL) || (m == NULL)).Resolves #833
Signed-off-by: Ivan Kozlovic [email protected]