feat: use json string to store additional metadata in fasta headers #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal is to use stringified JSON to add any additional data to fasta headers as opposed to home-grown format.
Advantages:
json.loads()
"Disadvantages:
Example outputs:
Before:
After:
Note that in this particular example, because values are delimited with
-
and thepath_name
contains-
it is difficult or impossible to reliably extract the values from the "before" format string. Changing delimiter won't help here, becausepath_name
itself comes from fasta and can contain any characters. The only reliable way to write this is to have a list of reserved characters and a strategy to escape them.