Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix note block interaction causing doubled note increase #1939

Fix note block interaction causing doubled note increase

fe2fc98
Select commit
Loading
Failed to load commit list.
Merged

Fix note block interaction causing doubled note increase #1939

Fix note block interaction causing doubled note increase
fe2fc98
Select commit
Loading
Failed to load commit list.
NeoForged - PR Publishing / PR Publishing succeeded Feb 4, 2025 in 17s

PR Publishing - 2 artifacts

PR published 2 artifacts
net.neoforged:neoforge:21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling
net.neoforged:testframework:21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling

Details

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1939' // https://github.com/neoforged/NeoForge/pull/1939
        url 'https://prmaven.neoforged.net/NeoForge/pr1939'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1939.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1939
cd NeoForge-pr1939
curl -L https://prmaven.neoforged.net/NeoForge/pr1939/net/neoforged/neoforge/21.4.82-beta-pr-1939-fix-1.21.4-GH-1938-noteblock-note-doubling/mdk-pr1939.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.