Bump elixir/erlang and dependencies & add timezone to airports #22

dgigafox · 2024-07-19T07:13:33Z

Changes:

Bump elixir from 1.16 to 1.17 and erlang from 26.2 to 27.0
Add timezone data accessible through the timezone_id field of the Airport struct which can be updated using mix airports.update. The source of timezone data is tz_world
Bump other mix dependencies

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [dialyxir](https://github.com/jeremyjh/dialyxir) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/jeremyjh/dialyxir/releases) - [Changelog](https://github.com/jeremyjh/dialyxir/blob/master/CHANGELOG.md) - [Commits](jeremyjh/dialyxir@1.1.0...1.2.0) --- updated-dependencies: - dependency-name: dialyxir dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…checkout-3 Bump actions/checkout from 2 to 3

Bump dialyxir from 1.1.0 to 1.2.0

Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.14.6 to 0.16.1. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.14.6...v0.16.1) --- updated-dependencies: - dependency-name: excoveralls dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bump excoveralls from 0.14.6 to 0.16.1

Skip header when parsing CSV

Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.29.4 to 0.30.6. - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.29.4...v0.30.6) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

…/checkout-4 Bump actions/checkout from 3 to 4

Bump ex_doc from 0.29.4 to 0.30.6

feat(WEB-0): Update csv source

Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.31.0 to 0.31.1. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bump ex_doc from 0.31.0 to 0.31.1

update tests

feat(WEB-7334): Add API for getting timezone based on IATA code

Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.34.1 to 0.34.2. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.34.1...v0.34.2) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [castore](https://github.com/elixir-mint/castore) from 1.0.7 to 1.0.8. - [Commits](elixir-mint/castore@v1.0.7...v1.0.8) --- updated-dependencies: - dependency-name: castore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bump elixir from 1.16 to 1.17 and erlang from 26.2 to 27.0

Bump castore from 1.0.7 to 1.0.8

Bump ex_doc from 0.34.1 to 0.34.2

sjoulbak

Hey @dgigafox 👋 Thanks for your contribution! I ran mix airports.update locally and liked the progress indicator. I did not had any changes, so its looking good 👌 A nice addition for in the future would be to first update priv/airports.csv in the same command 😄

I left a few comments, could you take a look at those?

mix.exs

README.md

sjoulbak · 2024-07-19T08:28:47Z

lib/airport.ex

@@ -16,6 +17,7 @@ defmodule Airports.Airport do
    :local_code,
    :home_link,
    :wikipedia_link,
-    :keywords
+    :keywords,
+    :timezone_id


Could you add a changelog entry at 1.0.0 for this addition?

sjoulbak · 2024-07-19T08:35:14Z

lib/airports/loader.ex

+  def run do
+    source_path()
+    |> File.stream!()
+    |> AirportsParser.parse_stream(skip_headers: true)


Could you add a changelog entry for this addition as well?

sjoulbak · 2024-07-19T09:16:10Z

.github/workflows/elixir.yml

Can you make this branch up-to-date with its base branch? I added pull_request to the github action workflow, so it will run here as well.

Having a problem with github action on push and pull request as it doubles the job and I'm getting this error:

** (ExCoveralls.ReportUploadError) Failed to upload the report to 'https://coveralls.io/' (reason: status_code = 422, body = {"message":"Can't add a job to a build that is already closed. Build 4a906ff5af85935d69cae47d180084dacce7e615-PR-43 is closed. See docs.coveralls.io/parallel-builds","error":true}).

@samhamilton could you take a look at this one too?

I think this is caused by the following change: d23b5b9

@dgigafox I pushed a new change to the branch. Hopefully that will fix it. Can you make this branch up-to-date with its base branch again?

Inspired by: https://github.com/orgs/community/discussions/26276#discussioncomment-3251154

Change requests from upstream

dgigafox · 2024-07-19T11:51:47Z

@sjoulbak change requests are pushed. Please take a look again. Thanks!

Btw, about

A nice addition for in the future would be to first update priv/airports.csv in the same command 😄

Agree on this. Will take a look at that

coveralls · 2024-07-19T11:57:36Z

Pull Request Test Coverage Report for Build 7d1162caeb87b3db1b9c366b6a9261d5ccfd5a7c-PR-22

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

4 of 31 (12.9%) changed or added relevant lines in 3 files are covered.
13 unchanged lines in 1 file lost coverage.
Overall coverage increased (+3.3%) to 5.155%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/airports/loader.ex	0	4	0.0%
lib/mix/tasks/update.ex	0	23	0.0%

Files with Coverage Reduction	New Missed Lines	%
deps/nimble_csv/lib/nimble_csv.ex	13	0.0%

Totals
Change from base Build d23b5b9ca5e36ef8c3bc8bbb7504f7af4bd08b82:	3.3%
Covered Lines:	5
Relevant Lines:	97

💛 - Coveralls

dgigafox · 2024-07-19T11:59:56Z

@sjoulbak error on workflow appeared again because I think this is both a pull request and a pull to master.

sjoulbak · 2024-07-19T12:03:47Z

@dgigafox Its fine by me if you remove excoveralls from the workflow for now, but keep it in the code base so we can run it locally. Currently we're not covering a lot for this package

Replace coveralls with test

dgigafox · 2024-07-23T05:00:42Z

@dgigafox Its fine by me if you remove excoveralls from the workflow for now, but keep it in the code base so we can run it locally. Currently we're not covering a lot for this package

@sjoulbak We replaced the coveralls with a simple mix test. All green now

sjoulbak

🎉

sjoulbak · 2024-07-23T06:06:57Z

@dgigafox and @samhamilton Thanks both for all of your effort! 🎉 I've released 1.0.0 🎉

dependabot bot and others added 30 commits April 1, 2022 15:04

Merge pull request #4 from martide/dependabot/github_actions/actions/…

db7fffe

…checkout-3 Bump actions/checkout from 2 to 3

Merge pull request #8 from martide/dependabot/hex/dialyxir-1.2.0

240bf45

Bump dialyxir from 1.1.0 to 1.2.0

Bump ex_doc from 0.28.0 to 0.28.5 (#10)

5c4eda2

Bump excoveralls from 0.14.4 to 0.14.6 (#9)

0b6330b

Merge pull request #17 from martide/dependabot/hex/excoveralls-0.16.1

13ff2fc

Bump excoveralls from 0.14.6 to 0.16.1

Skip header when parsing csv

3e424bc

Merge pull request #19 from martide/fix/remove-header

5c32ca5

Skip header when parsing CSV

Bump dialyxir from 1.2.0 to 1.3.0 (#18)

24019ef

Bump ex_doc from 0.28.5 to 0.29.4 (#16)

ea3fe6b

Merge pull request #24 from martide/dependabot/github_actions/actions…

aff4172

…/checkout-4 Bump actions/checkout from 3 to 4

Merge pull request #22 from martide/dependabot/hex/ex_doc-0.30.6

b66c916

Bump ex_doc from 0.29.4 to 0.30.6

Bump deps

eadb24d

add castore

e2b76d1

Update source csv

41f5f30

Update tool versions

bd34228

Merge pull request #28 from martide/feat/update-csv-source

8cb595f

feat(WEB-0): Update csv source

Merge pull request #29 from martide/dependabot/hex/ex_doc-0.31.1

d8a0155

Bump ex_doc from 0.31.0 to 0.31.1

Bump ex_doc from 0.31.1 to 0.31.2 (#30)

04d1195

Bump castore from 1.0.5 to 1.0.6 (#31)

9e3a23c

update tests

6081e2c

Merge pull request #34 from martide/gh

aa4807a

update tests

Bump packages

aaac699

Add API to get timezone based on airport code

e7d702a

Save timezone to source file for faster retrieve

6d58213

alexfilippovw and others added 11 commits June 6, 2024 21:05

Merge pull request #37 from martide/feat/timezones

7d23b30

feat(WEB-7334): Add API for getting timezone based on IATA code

Bump ex_doc from 0.32.0 to 0.34.1 (#39)

3687c11

Bump castore from 1.0.6 to 1.0.7 (#36)

a970acf

Merge branch 'nerds-and-company:master' into master

93fc9cc

Bump elixir to 1.17 and erlang to 27.0

f20ac88

Fix github workflow

bf6b53e

Merge pull request #42 from martide/bump-elixir-erlang

1b3b71a

Bump elixir from 1.16 to 1.17 and erlang from 26.2 to 27.0

Merge pull request #41 from martide/dependabot/hex/castore-1.0.8

6ffba26

Bump castore from 1.0.7 to 1.0.8

Merge pull request #40 from martide/dependabot/hex/ex_doc-0.34.2

c3cd313

Bump ex_doc from 0.34.1 to 0.34.2

sjoulbak mentioned this pull request Jul 19, 2024

[Bugfix] Skip headers when parsing csv #4

Closed

sjoulbak reviewed Jul 19, 2024

View reviewed changes

sjoulbak and others added 5 commits July 19, 2024 19:40

chore(github actions): let elixir workflow run on push and pull_request

a485155

fix(github actions): prevent actions being ran twice

2684417

Inspired by: https://github.com/orgs/community/discussions/26276#discussioncomment-3251154

Update CHANGELOG

2e93850

Run castore on test only

dfbc34c

Merge pull request #43 from martide/change-request-from-upstream

7d1162c

Change requests from upstream

dgigafox and others added 2 commits July 22, 2024 14:38

Replace coveralls with test

490b7f9

Merge pull request #44 from martide/remove-coveralls-from-workflow

83f9195

Replace coveralls with test

sjoulbak approved these changes Jul 23, 2024

View reviewed changes

sjoulbak merged commit 80bdc8a into nerds-and-company:master Jul 23, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump elixir/erlang and dependencies & add timezone to airports #22

Bump elixir/erlang and dependencies & add timezone to airports #22

dgigafox commented Jul 19, 2024

sjoulbak left a comment

sjoulbak Jul 19, 2024

dgigafox Jul 19, 2024

sjoulbak Jul 19, 2024

dgigafox Jul 19, 2024

sjoulbak Jul 19, 2024

dgigafox Jul 19, 2024

dgigafox Jul 19, 2024

sjoulbak Jul 19, 2024

sjoulbak Jul 19, 2024

dgigafox commented Jul 19, 2024

coveralls commented Jul 19, 2024

dgigafox commented Jul 19, 2024

sjoulbak commented Jul 19, 2024

dgigafox commented Jul 23, 2024 •

edited

Loading

sjoulbak left a comment

sjoulbak commented Jul 23, 2024

Bump elixir/erlang and dependencies & add timezone to airports #22

Bump elixir/erlang and dependencies & add timezone to airports #22

Conversation

dgigafox commented Jul 19, 2024

sjoulbak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgigafox commented Jul 19, 2024

coveralls commented Jul 19, 2024

Pull Request Test Coverage Report for Build 7d1162caeb87b3db1b9c366b6a9261d5ccfd5a7c-PR-22

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

dgigafox commented Jul 19, 2024

sjoulbak commented Jul 19, 2024

dgigafox commented Jul 23, 2024 • edited Loading

sjoulbak left a comment

Choose a reason for hiding this comment

sjoulbak commented Jul 23, 2024

dgigafox commented Jul 23, 2024 •

edited

Loading