Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Add support for prediction to NRQL alert conditions #1271

Conversation

founddrama
Copy link
Contributor

@founddrama founddrama commented Feb 20, 2025

  • Adds support for the prediction fields on NRQL alert conditions
  • prediction field is only available for static NRQL conditions (not baseline/anomaly conditions)
  • Current state of the feature: released internally and open to limited preview (public preview coming shortly)

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.89%. Comparing base (3ff4ee2) to head (4033306).
Report is 151 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   38.84%   34.89%   -3.95%     
==========================================
  Files          86      127      +41     
  Lines        5612     7648    +2036     
==========================================
+ Hits         2180     2669     +489     
- Misses       3266     4799    +1533     
- Partials      166      180      +14     
Flag Coverage Δ
unit 34.89% <ø> (-3.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic
Copy link
Member

👀

@pranav-new-relic
Copy link
Member

pranav-new-relic commented Feb 20, 2025

image image

looks like the fork being out of sync is playing spoilsport. I'll try and update this done 👍

@pranav-new-relic pranav-new-relic force-pushed the NR-336017/add_forecast_to_nrql_condition branch from 0cdeb2a to 7a02580 Compare February 20, 2025 17:20
@pranav-new-relic
Copy link
Member

image

we're good now 👍

@pranav-new-relic
Copy link
Member

image

Copy link
Member

@pranav-new-relic pranav-new-relic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pranav-new-relic pranav-new-relic merged commit a641c1f into newrelic:main Feb 21, 2025
11 checks passed
@founddrama founddrama deleted the NR-336017/add_forecast_to_nrql_condition branch February 21, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants