Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous text #804

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Fix anonymous text #804

merged 1 commit into from
Mar 8, 2021

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Feb 24, 2021

Now we have:

  • Explicitely set Anonymous -> Anonymous Text
  • NOT explicitely anonymous && Logged-In -> ConnectedToAccount Text
  • NOT explicitely anonymous && NOT Logged-In -> No text.

This seems to me like beeing, what we actually explicitely do. Third case is not explictely wanted as Anonymous, we just call them Anonymous user, as we don't have a connected account. This also allows e.g. to create Public Forms with a Name Field (not anonymous), without the Anonymous-Text.

Fixes #782.

@jotoeri jotoeri added bug Something isn't working 3. to review Waiting for reviews labels Feb 24, 2021
@jotoeri jotoeri added this to the 2.2 milestone Feb 24, 2021
@jotoeri jotoeri marked this pull request as ready for review February 26, 2021 09:09
Signed-off-by: Jonas Rittershofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compulsory 'anonymous' or 'connected to Nextcloud account' text problematic
2 participants