add notes path to capabilities

[tobiasKaminsky]

No description provided.

[tobiasKaminsky]

@juliusknorr thanks! Tested & works!

[enjeck]

@tobiasKaminsky Some CI tests are failing

[tobiasKaminsky]

@juliusknorr or @enjeck can you help me with psalm?

ERROR: RiskyTruthyFalsyComparison
at /home/tobi/github/nextcloud/notes/lib/AppInfo/Capabilities.php:29:21
Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
                                'notes_path' => $this->userId ? $this->noteUtil->getNotesFolderUserPath($this->userId) : null,

Not sure what to do.

[enjeck]

I haven't looked deeply yet, but my first thought is that maybe the warning is about $this->userId which could be null or the empty string, and both cases are falsy. So maybe changing to $this->userId !== null && $this->userId !== " "? $this->noteUtil->getNotesFolderUserPath($this->userId) : null

[enjeck]

There seem to be other unrelated CI failures like the test-api (min). I can look into that

[tobiasKaminsky]

@juliusknorr I am sorry, but I give up on this.
I am not familar with it, and having two lines of code changes, killing the entire CI… 🤷