Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add search message tab to the right sidebar #14125

Merged
merged 9 commits into from
Jan 16, 2025
Merged

feat: Add search message tab to the right sidebar #14125

merged 9 commits into from
Jan 16, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 13, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Recording.2025-01-15.091600.mp4

🚧 Tasks

  • Check nexttick effect in MessagesList (scrollToBottom and focusMessage are now at the same time)
  • Remove types

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad requested a review from Antreesy January 13, 2025 17:04
@DorraJaouad DorraJaouad self-assigned this Jan 13, 2025
@DorraJaouad DorraJaouad added this to the 🌿 Next Beta (31) milestone Jan 13, 2025
@DorraJaouad DorraJaouad force-pushed the feat/11130/search-messages branch from e1a4ae8 to 584b53c Compare January 14, 2025 15:56
@DorraJaouad DorraJaouad changed the title Add search message tab to the right sidebar Feat: Add search message tab to the right sidebar Jan 15, 2025
@DorraJaouad DorraJaouad marked this pull request as ready for review January 15, 2025 08:17
Antreesy
Antreesy reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise OK, let's finish the critical things and proceed in follow-ups

src/types/index.ts Outdated Show resolved Hide resolved
src/components/RightSidebar/RightSidebar.vue Show resolved Hide resolved
src/components/RightSidebar/RightSidebar.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Outdated Show resolved Hide resolved
src/components/RightSidebar/SearchMessages/SearchMessagesTab.vue Show resolved Hide resolved
@miaulalala miaulalala changed the title Feat: Add search message tab to the right sidebar feat: Add search message tab to the right sidebar Jan 16, 2025
@DorraJaouad DorraJaouad force-pushed the feat/11130/search-messages branch 3 times, most recently from 572fb3d to b56de1c Compare January 16, 2025 13:22
JungleDruid and others added 8 commits January 16, 2025 14:23
@JungleDruid @DorraJaouad
fix: Add search message tab to the right sidebar
f985963 
Signed-off-by: JungleDruid <[email protected]>
@JungleDruid @DorraJaouad
fix: Change the component structure to Vue 3 setup and TypeScript
26a0e1f 
Signed-off-by: JungleDruid <[email protected]>
@DorraJaouad
fix: change to button trigger for search messages instead of an addit…
2e94f03 
…ional tab

Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: rename icons with Icon*
9233d79 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix(SearchMessagesTab): Remove the date limitation and change to date…
a9503cd 
… scale instead of time. Change to native component

Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix(SearchMessagesTab): improve UI and correct some logical conditions
b449d0a 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
feat(SearchMessagesTab): show applied filters in chips
3a40407 
Signed-off-by: Dorra Jaouad <[email protected]>
@DorraJaouad
fix: handle in call routing
88b5b19 
Signed-off-by: Dorra Jaouad <[email protected]>
Antreesy
Antreesy approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works good enought for now. Let's get it in and continue with follow-ups

@DorraJaouad DorraJaouad force-pushed the feat/11130/search-messages branch from b56de1c to d302936 Compare January 16, 2025 13:52
@DorraJaouad DorraJaouad enabled auto-merge January 16, 2025 13:53
@DorraJaouad DorraJaouad merged commit 1516369 into main Jan 16, 2025
50 checks passed
@DorraJaouad DorraJaouad deleted the feat/11130/search-messages branch January 16, 2025 13:54
@Antreesy Antreesy mentioned this pull request Jan 16, 2025
Closed
10 tasks
@DorraJaouad DorraJaouad mentioned this pull request Jan 16, 2025
Open
13 tasks
@nickvergessen nickvergessen mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v21.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Search inside Talk App doesn't include talk messages
3 participants
@DorraJaouad @Antreesy @JungleDruid