Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update msa config CRG #842

Merged
merged 1 commit into from
Feb 4, 2025
Merged

update msa config CRG #842

merged 1 commit into from
Feb 4, 2025

Conversation

luisas
Copy link
Contributor

@luisas luisas commented Feb 4, 2025


Update MSA config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is because these settings are already in the main crg profile

@luisas
Copy link
Contributor Author

luisas commented Feb 4, 2025

I assume this is because these settings are already in the main crg profile

Yes! Thanks for the review :)

@luisas luisas merged commit 8a6bf94 into nf-core:master Feb 4, 2025
140 checks passed
@luisas luisas deleted the update_msa branch February 4, 2025 11:36
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants