Add clusterId and checks for KubernetesOperators registration

[hjkatz]

What

Describe what the change is solving

During k8sop registration we try to match the k8sop in ngrok API with the configured KubernetesOperator in ngrok-operator.

Currently we're matching on:

• operator name
• operator namespace
• operator namespace UID
• operator binding name (if exists)

But, the operator name and namespace may be the same (likely) in different clusters, however we do not have a field to check for cluster name/id.

So this PR tentatively adds that feature (but doesn't implement the ngrok API side of things just yet).

How

Describe the solution

Breaking Changes

Are there any breaking changes in this PR?

Yes, .Values.clusterId is now a required field.

[hjkatz]

• Add clusterId and checks for KubernetesOperators registration #474 👈 (View in Graphite)
• Support one-click-demo mode #503
• Hide ngrok-op API registration behind bindings feature flag #504
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alex-bezek]

I think we need a way to have this not be supplied for an initial install. The requirements we talked about in slack are detained a bit better by this old issue where we resolved the issue that we required an authtoken and API key on start #317

[hjkatz]

I'm reading from that issue that the desire is the ngrok-operator can be installed into a non-functional/non-reconciling state and we give an error event on the kind: KubernetesOperator itself.

Is that what you mean?

[alex-bezek]

yep, i think something like that would fufill the requirements. Similarly, if you one click install, the operator is just going to log and event that it needs the credentias I believe. The idea is a helm instal without custom options should "just work" to at least helm install, but it may not fully function.