Support one-click-demo mode #503
Conversation
github-actions
bot
added
area/controller
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hjkatz
force-pushed
the
hkatz/one-click-demo
branch
from
557b190
to
3059edc
Compare
hjkatz
force-pushed
the
hkatz/one-click-demo
branch
from
3059edc
to
68b56c1
Compare
| nameOverride: "" | ||
| fullnameOverride: "" | ||
| description: "The official ngrok Kubernetes Operator." | ||
| commonLabels: {} | ||
| commonAnnotations: {} | ||
| oneClickDemoMode: false |
There was a problem hiding this comment.
doesn't this need to be set to true in order for it to work without having to set any required fields? Or do these on click app marketplaces allow specifying a helm value like this by default and its just we can't require user specific values to be set like API crednetials?
There was a problem hiding this comment.
Or do these on click app marketplaces allow specifying a helm value like this by default and its just we can't require user specific values to be set like API crednetials?
The latter: My understanding is we can provide a values.yaml but not a pop-up for required fields. So we'll set onClickDemoMode: true in those marketplace values.
There was a problem hiding this comment.
ahh ok, thats good to know, thanks
There was a problem hiding this comment.
if we can provide default values i'm kinda surprised we didn't just default these installations' replica count to 0 and instruct you to scale up after provider credentials vs a no-op mode, but I don't think I have all the historic context here
What
Describe what the change is solving
We would like to support a 1-click installation for marketplace environments.
However, these environments do not allow users to provide required config before 1-click installing.
And, the installation is only successful if the Pod goes Ready (helm install success).
But, our ngrok-op requires user configuration to work, namely API key and authtoken.
So we provide this new
oneClickDemoMode: true/falsevalue that can change the behaviour of the installed ngrok-op.How
Describe the solution
Factor out startup functions
Add oneClickDemoMode to helm values.yaml
Breaking Changes
Are there any breaking changes in this PR?
No.