Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Allow style tags and attributes in the In-App & Email Editor #4841

Conversation

rifont
Copy link
Collaborator

@rifont rifont commented Nov 13, 2023

What change does this PR introduce?

Adds preservation of style tags and attributes through the sanitize-html library configuration options. In-App and Email HTML content now preserves style tags and attributes on save.

Why was this change needed?

Closes NV-3026

Other information (Screenshots)

In-App Editor Update: Preserving Style Tags and Attributes - Watch Video

Copy link

linear bot commented Nov 13, 2023

NV-3026 On update button click, css styles are removed in in-app template editor

Try these content

<style>
p {color: red;}
</style>
<p>This is a paragraph.</p>

or

<p style="color:red;">A red paragraph.</p>

@jainpawan21 jainpawan21 merged commit 635af2b into next Nov 14, 2023
18 checks passed
@jainpawan21 jainpawan21 deleted the nv-3026-on-update-button-click-css-styles-are-removed-in-in-app branch November 14, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants