Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): use correct quotes in shell comparison in dockerfiles #5119

Closed
wants to merge 1 commit into from

Conversation

MasonD
Copy link
Contributor

@MasonD MasonD commented Jan 25, 2024

What change does this PR introduce?

Change from single quotes to double quotes in Dockerfiles

Why was this change needed?

Closes #5052

Copy link

netlify bot commented Jan 25, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit fcc37a7

@scopsy
Copy link
Contributor

scopsy commented Jan 28, 2024

@AliaksandrRyzhou / @Cliftonz would appreciate your assistance in verifying this change

@AliaksandrRyzhou
Copy link
Contributor

Great notice @MasonD, you're absolutely right, in this case this won't be working with single quotes. But I'm concerned that we have a risk to share BULL_MQ_PRO_NPM_TOKEN with anyone who downloads an image and looks at a docker image history/docker inspect information.
It also will be visible during docker build process (if GitHub doesn't hide it).
Here is a little information about it and a way how we can do this.

@MasonD
Copy link
Contributor Author

MasonD commented Jan 30, 2024

This sounds like a problem that exists with the current implementation regardless of whether the quotes are fixed, so seems pretty important to solve quickly. Are you going to handle that internally?

@AliaksandrRyzhou
Copy link
Contributor

@MasonD Thank you for your help! We close this because PR5131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Docker containers always try to build enterprise version
3 participants