fix(ci): Changed the process of token getting. From docker arguments …

[AliaksandrRyzhou]

What change does this PR introduce?

Docker containers always try to build enterprise version. Here it was suggested to use double quotes instead of single so it actually works as intended. But if we change single quotes to double quotes the variable BULL_MQ_PRO_NPM_TOKEN will be visible every time during a docker build process. Even if we try to hide it the Docker build best practice doesn't recommend to use arguments and environment variables for secret values. Anyone can take a look at this values using "docker image history" ot "docker inspect"

Why was this change needed?

• Closes 5052
• It should securely leverage the Bullmq pro token to correctly identify if we are building the community or enterprise edition.
• Build arguments and environment variables are inappropriate for passing secrets to your build, because they persist in the final image. Instead, should use secret mounts or SSH mounts, which expose secrets to your builds securely.

[linear]

INF-184 🐛 Bug Report: Docker containers always try to build enterprise version

[netlify]

❌ Deploy Preview for dev-web-novu failed.

Name	Link
🔨 Latest commit	707b02f
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/65ba0cb6e76ddb00082303a7

[LetItRock]

looks good to me! 🔥
maybe before merging these changes to next we can try the full deployment to the dev env? and we can also verify that the images that are built include the bullmq-pro package in the node_modules.

[AliaksandrRyzhou]

looks good to me! 🔥

maybe before merging these changes to next we can try the full deployment to the dev env? and we can also verify that the images that are built include the bullmq-pro package in the node_modules.

This is a very good idea Pawel. I'll do as you say

[scopsy]

Just as a small note, it's not really a huge issues since the ee dockers are in the private repository. But I totally agree that it's a better practice