tests: benchmarks: power_consumption: i2c: Fix increased power consumpion #19861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 7ab054fd8cc3914d7c060c992b06249cc5d4edd2 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: 11349092be Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
nordic-segl
reviewed
Jan 13, 2025
| @@ -12,6 +12,16 @@ const struct gpio_dt_spec led = GPIO_DT_SPEC_GET(DT_ALIAS(led2), gpios); | |||
| static bool state = true; | |||
| extern void thread_definition(void); | |||
|
|
|||
| /* Some tests requires that test thread controls when the moment when it is | |||
There was a problem hiding this comment.
Some tests require that test thread controls when it is suspended.
nordic-piks
approved these changes
Jan 13, 2025
nordic-krch
force-pushed
the
i2c_power_consumption
branch
2 times, most recently
from
75d72ad to
7ab054f
Compare
Test was suspending test thread from the timer interrupt at random (but periodic) point. Some drivers which are tested in that framework handles power management in the thread context. Randomly suspending the test thread could lead to a case where driver did not finish requested operation and system goes to s2ram in the middle of the driver operation. Extending the test framework to allow more controlled thread suspension. Timer can indicate to the thread that is shall be suspended and thread calls self suspension when ready. Signed-off-by: Krzysztof Chruściński <[email protected]>
Test thread cannot be suspended at any time because driver power management happens in the thread context so if thread is suspended at the random moment and system goes to s2ram it can lead to increased power consumption because thread got suspended before i2c device got properly suspended. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add property to enable runtime PM for i2c and spi used for controlling the sensor. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-segl
approved these changes
Jan 13, 2025
nordicjm
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was suspending test thread from the timer interrupt at random (but periodic) point. I2c driver handles power management in the thread context. Randomly suspending the test thread could lead to a case where driver did not finish requested operation and system goes to s2ram in the middle of the driver operation.
PR extends framework to allow optional requesting of the test thread suspension (instead of forcing) and test thread suspends itself when requested. It is done after driver operation is finished.
Additionally, added enabling of the runtime power management to the i2c instance used by the shield used in the test.