Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 11 #2508

Merged
merged 26 commits into from
Mar 28, 2024
Merged

Support Laravel 11 #2508

merged 26 commits into from
Mar 28, 2024

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Feb 18, 2024

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Allow installation alongside Laravel 11.

Breaking changes

None.

@spawnia
Copy link
Collaborator Author

spawnia commented Feb 18, 2024

Requires BenSampo/laravel-enum#353.

@elliottlawson
Copy link

@spawnia would like to pull this in on a Laravel 11 project, anything I can help with to move this forward?

@chojnicki
Copy link

chojnicki commented Mar 17, 2024

Requires BenSampo/laravel-enum#353.

@spawnia Hmm but why lighthouse cannot work with PHP native enums? Even author suggests not to use that package.

Edit: Now I see that you are maintaining laravel-enums, and you actually commited "Using this library is no longer recommended", so I'm now even more confused :P

composer.json Outdated Show resolved Hide resolved
@vanbosse
Copy link

vanbosse commented Mar 21, 2024

@spawnia can we help you out in order to push this forward?

@spawnia
Copy link
Collaborator Author

spawnia commented Mar 21, 2024

@spawnia can we help you out in order to push this forward?

Sure, thank you for the offer. I just pushed a change to allow the CI pipelines to run in principle. You can send a merge request that targets this branch and fixes some of the issues in PHPUnit or PHPStan.

@nhedger
Copy link
Contributor

nhedger commented Mar 25, 2024

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

@spawnia
Copy link
Collaborator Author

spawnia commented Mar 25, 2024

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

I am not planning to drop support just yet. It is just impossible to install alongside Laravel 11 for testing, so I am dropping it as a dev dependency. We can just ignore the PHPStan errors.

@chojnicki
Copy link

I am not planning to drop support just yet.

I hope you meant "never" ❤️

@nhedger
Copy link
Contributor

nhedger commented Mar 25, 2024

@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it.

I am not planning to drop support just yet. It is just impossible to install alongside Laravel 11 for testing, so I am dropping it as a dev dependency. We can just ignore the PHPStan errors.

Sounds good!

@spawnia spawnia added the enhancement A feature or improvement label Mar 28, 2024
@spawnia spawnia marked this pull request as ready for review March 28, 2024 09:29
@spawnia spawnia merged commit 3f96f47 into master Mar 28, 2024
41 of 43 checks passed
@spawnia spawnia deleted the laravel-11 branch March 28, 2024 09:35
@spawnia
Copy link
Collaborator Author

spawnia commented Mar 28, 2024

Thank you @nhedger. Released with https://github.com/nuwave/lighthouse/releases/tag/v6.36.0.

@njoguamos
Copy link

Thank you all.

@nhedger
Copy link
Contributor

nhedger commented Mar 28, 2024

Thank you @spawnia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants