-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Laravel 11 #2508
Support Laravel 11 #2508
Conversation
Requires BenSampo/laravel-enum#353. |
@spawnia would like to pull this in on a Laravel 11 project, anything I can help with to move this forward? |
@spawnia Hmm but why lighthouse cannot work with PHP native enums? Even author suggests not to use that package. Edit: Now I see that you are maintaining laravel-enums, and you actually commited "Using this library is no longer recommended", so I'm now even more confused :P |
@spawnia can we help you out in order to push this forward? |
Sure, thank you for the offer. I just pushed a change to allow the CI pipelines to run in principle. You can send a merge request that targets this branch and fixes some of the issues in PHPUnit or PHPStan. |
@spawnia I'm assuming you're dropping Lumen support. I can send a PR that removes references to Lumen that PHPStan complains about if you're ok with it. |
I am not planning to drop support just yet. It is just impossible to install alongside Laravel 11 for testing, so I am dropping it as a dev dependency. We can just ignore the PHPStan errors. |
I hope you meant "never" ❤️ |
Sounds good! |
Thank you @nhedger. Released with https://github.com/nuwave/lighthouse/releases/tag/v6.36.0. |
Thank you all. |
Thank you @spawnia! |
Changes
Allow installation alongside Laravel 11.
Breaking changes
None.