Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrabbiata: implement absorb_state #2982

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems marked this pull request as draft January 30, 2025 13:09
@dannywillems dannywillems force-pushed the arrabbiata/absorb-state branch from 00406df to d4ac188 Compare January 30, 2025 13:34
@dannywillems dannywillems changed the title Arrabbiata/absorb state Arrabbiata: implement absorb_state Jan 30, 2025
@dannywillems dannywillems force-pushed the arrabbiata/absorb-state branch from d4ac188 to 6f88cba Compare January 30, 2025 13:37
@dannywillems dannywillems marked this pull request as ready for review January 30, 2025 13:38
@dannywillems dannywillems changed the base branch from arrabbiata/use-curve-instead-of-field to dw/prepare-absorb-state January 30, 2025 14:26
@dannywillems dannywillems marked this pull request as draft January 30, 2025 14:26
The verifier will need to recompute the challenges, and for this, we need to
keep track of the digest of the program state before we committed at the
previous iteration.

For the current iteration, we keep track also of the digest of the program state
we have to start from.
This will replace `sponge_e1` and `sponge_e2`.
@dannywillems dannywillems force-pushed the arrabbiata/absorb-state branch from 5504ea4 to 3b47ed2 Compare January 30, 2025 15:23
@dannywillems dannywillems marked this pull request as ready for review January 30, 2025 15:36
Base automatically changed from dw/prepare-absorb-state to master January 30, 2025 17:39
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.90%. Comparing base (51266d7) to head (3b47ed2).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2982      +/-   ##
==========================================
+ Coverage   76.80%   76.90%   +0.09%     
==========================================
  Files         261      261              
  Lines       61404    61455      +51     
==========================================
+ Hits        47159    47259     +100     
+ Misses      14245    14196      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems
Copy link
Member Author

For a follow-up: draw the diagram with the digest after and before execution.

@dannywillems dannywillems merged commit f6fa0b1 into master Feb 3, 2025
13 checks passed
@dannywillems dannywillems deleted the arrabbiata/absorb-state branch February 3, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants