Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhatsignedrpmcheck: Add remediation hint and URL #1326

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Jan 10, 2025

Users do not have an idea what they should do about the third party packages - and quite often they do not understand the report itself. Adding the remediation hint with a link to related KB solution to help them to understand what they can do about this.

Note the actor needs significant changes to cover also other non-RHEL distributions. I decided to keep the change simple and resolve that in a follow up when we enable upgrades on other distributions as well.

jira: RHEL-44596

Users do not have an idea what they should do about the third party
packages - and quite often they do not understand the report itself.
Adding the remediation hint with a link to related KB solution to
help them to understand what they can do about this.

Note the actor needs significant changes to cover also other non-RHEL
distributions. I decided to keep the change simple and resolve that
in a follow up when we enable upgrades on other distributions as well.

jira: RHEL-44596
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

  • /packit test to re-run manually the default tests
  • /packit retest-failed to re-run failed tests manually
  • /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - main - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

@pirat89 pirat89 added this to the 8.10/9.6 milestone Jan 10, 2025
@pirat89 pirat89 added the shortened-urls PR is introducing new shortened red.ht URLs label Jan 10, 2025
@tomasfratrik
Copy link
Member

The url link 'https://red.ht/customize-rhel-upgrade-actors' forwards me just to 'redhat.com', tried other 'red.ht' links and they forwarded me correctly.

@pirat89
Copy link
Member Author

pirat89 commented Jan 15, 2025

@tomasfratrik that's ok now, as the shortened URLs will be set/updated later. there are number of URLs now that do not even exist yet as we are waiting for RHEL 10 docs to be able to set them. this one is not such a case, but it will be set later when we go through the list of shortened URLs.

usually we parefer to have the links set before the merge, but with the new RHEL major version release, we are in situation where we cannot do it manytimes in advance and we will have to go anyway through all links in few months to set them. so it's ok

@tomasfratrik
Copy link
Member

tomasfratrik commented Jan 15, 2025

Now I understand, makes sense. Otherwise I tested it and it lgtm.

@pirat89 pirat89 added the enhancement New feature or request label Jan 17, 2025
@pirat89 pirat89 merged commit 2464051 into oamg:main Jan 17, 2025
21 of 24 checks passed
@pirat89 pirat89 deleted the unsigned-rpms-report branch January 17, 2025 11:43
@pirat89 pirat89 added the changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant enhancement New feature or request shortened-urls PR is introducing new shortened red.ht URLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants